bytecodealliance / bytecodealliance/wasmtime-py

Type mismatch in signature of `wasmtime._value._unintern()`

Open
#303 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
539
Forks
69
Avg merge
13m
Merged PRs (30d)
1

Description

The function is declared as accepting a single Python `int`

https://github.com/bytecodealliance/wasmtime-py/blob/170aca9e40a76fbf5e1ee77ab5ba33c46f093318/wasmtime/_value.py#L28-L29

However in both call sites `ctypes._Pointer[Any]` is supplied

https://github.com/bytecodealliance/wasmtime-py/blob/170aca9e40a76fbf5e1ee77ab5ba33c46f093318/wasmtime/_store.py#L43-L45

https://github.com/bytecodealliance/wasmtime-py/blob/170aca9e40a76fbf5e1ee77ab5ba33c46f093318/wasmtime/_value.py#L181-L182

this was uncovered during investigation of #302 on a branch derived from the nox branch for #301. I believe it is not currently detected due to several cases of `from ... import *`. This issue is probably not a high priority or severity, I'm mainly recording it as a reminder to myself.

```console
➜ wasmtime-py git:(nox) ✗ nox -p 3.14
nox > Running session tests-3.14
nox > Creating virtual environment (uv) using python3.14 in .nox/tests-3-14
nox > /Users/alex/.local/share/uv/tools/nox/bin/uv pip install '.[testing]'
nox > coverage run -m pytest
================================================ test session starts =================================================
platform darwin -- Python 3.14.0, pytest-8.4.2, pluggy-1.6.0
rootdir: /Users/alex/src/wasmtime-py
configfile: pytest.ini
plugins: mypy-1.0.1
collected 258 items

ci/build-rust.py .F [ 0%]
ci/cbindgen.py . [ 1%]
...
wasmtime/loader.py . [100%]

====================================================== FAILURES ======================================================
____________________________________________________ test session ____________________________________________________
mypy exited with status 1.
_____________________________________________ [mypy] wasmtime/_store.py ______________________________________________
46: error: Argument 1 to "_unintern" has incompatible type "_Pointer[Any]"; expected "int" [arg-type]
_____________________________________________ [mypy] wasmtime/_value.py ______________________________________________
184: error: Argument 1 to "_unintern" has incompatible type "_Pointer[Any]"; expected "int" [arg-type]
======================================================== mypy ========================================================
Found 2 errors in 2 files (checked 154 source files)
============================================== short test summary info ===============================================
FAILED ci/build-rust.py::mypy-status
FAILED wasmtime/_store.py::mypy
FAILED wasmtime/_value.py::mypy
=========================================== 3 failed, 255 passed in 17.63s ===========================================
nox > Command coverage run -m pytest failed with exit code 1
nox > Session tests-3.14 failed.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.