bytecodealliance / bytecodealliance/wasm-tools

Finish implementation of `versionsuffix` and `cm-canon-names`

Open
#2,556 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.8k
Forks
351
Avg merge
16h 57m
Merged PRs (30d)
38

Description

I started some work in https://github.com/bytecodealliance/wasm-tools/pull/2555, but there is remaining work to do. Notably:

* Right now it's validated that the suffix and prefix together make a complete semver, but the exact split point shoudl be subject to some sort of validation rule. I think this is something where the upstream spec will need to be consulted and kept in sync.
* Right now the validation I implemented, that the prefix/suffix combo is required to be a valid semver, is technically more restrictive than the upstream spec. This probably wants to be sync'd.
* There's no integration with `wit-component` right now, meaning you cannot create a component that uses `versionsuffix`.
* There's no way to have a core wasm module import from `wasi:filesystem/types@0.3`, for example, and get that integrated into `wit-component`.
* Emission of `versionsuffix` in `wit-component` will want to be conditional to start while runtimes catch up. There'll need to be some switch to say "yes do the thing" where without the switch full semver versions are emitted.
* The version-matching algorithms in wit-parser and wit-component will want to get tweaked to handle this new form of imports. Or, rather, I assume that something about them will want some handling.

Contributor guide

Open the contributing guide

Research direction

Review PR 2555 first to understand the existing versionsuffix and cm-canon-names work. Then inspect wit-parser and wit-component, and consult the upstream specification for split-point and semver validation. Done means completing the specified validation, component integration, conditional emission, and version-matching support.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, wasm
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.