bytecodealliance / bytecodealliance/wasm-tools

Correctly calculate type size for indexed types

Open
#1,036 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.8k
Forks
351
Avg merge
16h 57m
Merged PRs (30d)
38

Description

Currently, for funcs the size is just a number of all of func's parameters and returned values + 1, and, for arrays it's just 2.

This'll need to change because the "type size" query is intended to encapsulate the recursive size of the type, so it needs to be 1 plus the size of the payload of the array.

_Originally posted by @alexcrichton in https://github.com/bytecodealliance/wasm-tools/pull/1022#discussion_r1192457577_

We need to calculate size for all known user defined types: funds, arrays and structs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.