bytecodealliance / bytecodealliance/wasm-pkg-tools

Move workspace test into e2e format

Open
#234 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
160
Forks
42
Avg merge
7h 57m
Merged PRs (30d)
3

Description

NIT: I really wonder if these should be fixtures. Feels wasteful to add like 10 new folders, but also feels unfortunate to write temp files in the unit tests.

_Originally posted by @vados-cosmonic in https://github.com/bytecodealliance/wasm-pkg-tools/pull/231#discussion_r3572392959_


Mimic `#[cargo_test]` e2es:
https://github.com/rust-lang/cargo/blob/a595d0da21f228b7fdae64d3d5c0e527ea66bb59/tests/testsuite/workspaces.rs#L2867-L2932

Contributor guide

Open the contributing guide

Research direction

Locate the current workspace test and compare it with Cargo's #[cargo_test] examples in tests/testsuite/workspaces.rs, especially lines 2867-2932. Determine how the test can follow that e2e format rather than writing temporary files in unit tests; done means the workspace behavior is covered by an e2e-style test without the discussed fixture or temporary-file drawback.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.