bytecodealliance / bytecodealliance/wasm-pkg-tools

[CLI] Shouldn't `--wit-dir` also change the place where we look-up for `wkg.(toml|lock)`?

Open
#137 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
160
Forks
42
Avg merge
7h 57m
Merged PRs (30d)
3

Description

Hello!

I have a repo with multiple WIT packages, I use [this option](https://github.com/bytecodealliance/wasm-pkg-tools/blob/main/crates/wkg/src/wit.rs#L46), so I can build my different package.

I noticed that we use the default `(Lock|Config)::load()`, but should we instead use [this function](https://github.com/bytecodealliance/wasm-pkg-tools/blob/main/crates/wasm-pkg-core/src/config.rs#L32) to load from the dir passed to `--wit-dir`?

If so, I would be happy to contribute back a quick MR! ❤️

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.