bytecodealliance / bytecodealliance/rustix
stop enabling dependencies in build.rs by default?
Open
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 294
- Avg merge
- 4h 7m
- Merged PRs (30d)
- 2
Description
(I'm basically using issues as a communication mechanism here)
See https://github.com/coreos/cargo-vendor-filterer/issues/71
TL;DR when rustix 0.37 came along with https://github.com/bytecodealliance/rustix/commit/a2c6c7a8b7adcf46592b7519ba90ecece18b4bd6 this ended up enabling `libc` by default and that pulled in the `errno` dependency by default.
However, `cargo metadata` doesn't see this dependency, it's only enabled via `build.rs`.
And that ends up breaking `cargo vendor-filterer`.
Since in reality, libc is enabled by default, ISTM we can rework the features and build scripts here right?
Contributor guide
Assessment
This issue has not been assessed yet.