bytecodealliance / bytecodealliance/rustix
Wrong flag used for (set_)ipv6_multicast_hops
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 294
- Avg merge
- 4h 7m
- Merged PRs (30d)
- 2
Description
v1.1.4
https://github.com/bytecodealliance/rustix/blob/035acdc416d9465abc937bd8cd6a0031afc170aa/src/backend/linux_raw/net/sockopt.rs#L568-L571
https://github.com/bytecodealliance/rustix/blob/035acdc416d9465abc937bd8cd6a0031afc170aa/src/backend/libc/net/sockopt.rs#L617-L620
These two cases (and their getter counterparts) should use `IPPROTO_IPV6`, not `IPPROTO_IP`.
A library I use had to work around this bug:
https://github.com/al8n/hick/pull/49/changes#diff-5f92e53a99f51d3b30937d394280111bf28c84ff3f340c6ad82a08364d2e0cb0R24-R32
I'm just here making sure the issue got reported upstream. 🫡
Contributor guide
Research direction
Start by reading the referenced sections in src/backend/linux_raw/net/sockopt.rs and src/backend/libc/net/sockopt.rs, then locate the getter counterparts for ipv6_multicast_hops. Verify that the affected setter and getter cases use IPPROTO_IPV6 rather than IPPROTO_IP, and confirm the relevant socket-option tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- linux, rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 84/100