bytecodealliance / bytecodealliance/StarlingMonkey

Remove -Wno-invalid-offsetof from compilation flags

Open
#269 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
288
Forks
57
PR merge metrics
No merged PRs in 30d

Description

As mentioned here: https://github.com/bytecodealliance/StarlingMonkey/pull/242#issuecomment-3201119743 we should re-enable this warning and use suppression maps from clang:

https://clang.llvm.org/docs/WarningSuppressionMappings.html

```
# .clang-suppression:
# Suppress -Winvalid-offsetof warnings in SpiderMonkey
[invalid-offsetof]
src:*/spidermonkey-debug/*
src:*/spidermonkey-release/*
```

This will be possible when we update to the version of `wasi-sdk` with `clang` version `>=20`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.