bumptech / bumptech/glide

Proguard R8 needs an update

Open
#5,460 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
35k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
8

Description

**Proguard file needs an update:**

The current version of R8 implicitly keeps the default constructor for Proguard configuration rules that have no member pattern. If the following rule should continue to keep the default constructor in the next major version of R8, then it must be augmented with the member pattern `{ void (); }` to explicitly keep the default constructor:
-keep public class * implements com.bumptech.glide.module.GlideModule

**Should be:**
```
-keep public class * implements com.bumptech.glide.module.GlideModule {
(...);
}
```

**Is:**
`-keep public class * implements com.bumptech.glide.module.GlideModule`

**File:**
https://github.com/bumptech/glide/blob/master/library/proguard-rules.txt

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.