bumptech / bumptech/glide

GeneratedAppGlideModuleImpl generated by ksp 'isManifestParsingEnabled' is always false

Open
#5,414 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
35k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
8

Description

**Glide Version**: 4.16.0

**Integration libraries**: no

**Device/Android Version**: android 13

**Issue details / Repro steps / Use case background**:
I upgraded kapt to ksp however the 'isManifestParsingEnabled' of the generated class no longer depends on
```
public boolean isManifestParsingEnabled() {
return true;
}
```
but always returns false.
```
internal class GeneratedAppGlideModuleImpl(
@Suppress("UNUSED_PARAMETER")
context: Context,
) : GeneratedAppGlideModule() {
private val appGlideModule: MyAppGlideModule
init {
appGlideModule = MyGlideModule()
}

public override fun registerComponents(
context: Context,
glide: Glide,
registry: Registry,
) {
GlideModule().registerComponents(context, glide, registry)
glideModule.registerComponents(context, glide, registry)
}

public override fun applyOptions(context: Context, builder: GlideBuilder) {
appGlideModule.applyOptions(context, builder)
}

// it is always false it not depends on 'appGlideModule' anymore
public override fun isManifestParsingEnabled(): Boolean = false
}
```

**Glide load line / `GlideModule` (if any) / list Adapter code (if any)**:
I am using manifest for parsing glide module, but it doesn't work if i use ksp.
```
@GlideModule
class MyAppGlideModule : AppGlideModule() {

override fun isManifestParsingEnabled(): Boolean {
return true
}

override fun registerComponents(
context: Context, glide: Glide, registry: Registry
) {
registry.register(SVG::class.java, PictureDrawable::class.java, SvgDrawableTranscoder())
.append(InputStream::class.java, SVG::class.java, SvgDecoder())
}
}

```

**Layout XML**:

**Stack trace / LogCat**:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.