bumptech / bumptech/glide

Ambiguous documentation of BitmapPool.get()

Open
#4,574 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
35k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
8

Description

> Implementations **can should** clear out every returned Bitmap using the following:

Maybe we should write here:

> Implementations **should** clear out every returned Bitmap using the following:

I think it would be more correct.

https://github.com/bumptech/glide/blob/a8c24c63c195306f82e36775d9f08f23c72c700e/library/src/main/java/com/bumptech/glide/load/engine/bitmap_recycle/BitmapPool.java#L50

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.