bumptech / bumptech/glide

Fix for bug https://github.com/bumptech/glide/issues/3195

Open
#4,419 1 comment 0 reactions 0 assignees View on GitHub
stale
Dominant language
Java
Stars
35k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
8

Description

Replace

return crossFade(new DrawableCrossFadeFactory.Builder(duration)
to
return crossFade(new DrawableCrossFadeFactory.Builder(duration).setCrossFadeEnabled(true));

and

return crossFade(new DrawableCrossFadeFactory.Builder());
to
return crossFade(new DrawableCrossFadeFactory.Builder().setCrossFadeEnabled(true));

in DrawableTransitionOptions class

public final class DrawableTransitionOptions
extends TransitionOptions {

/**
* Returns a {@link DrawableTransitionOptions} object that enables a cross fade animation.
*
* @see #crossFade()
*/
@NonNull
public static DrawableTransitionOptions withCrossFade() {
return new DrawableTransitionOptions().crossFade();
}

/**
* Returns a {@link DrawableTransitionOptions} object that enables a cross fade animation.
*
* @see #crossFade(int)
*/
@NonNull
public static DrawableTransitionOptions withCrossFade(int duration) {
return new DrawableTransitionOptions().crossFade(duration);
}

/**
* Returns a {@link DrawableTransitionOptions} object that enables a cross fade animation.
*
* @see #crossFade(DrawableCrossFadeFactory)
*/
@NonNull
public static DrawableTransitionOptions withCrossFade(
@NonNull DrawableCrossFadeFactory drawableCrossFadeFactory) {
return new DrawableTransitionOptions().crossFade(drawableCrossFadeFactory);
}

/**
* Returns a {@link DrawableTransitionOptions} object that enables a cross fade animation.
*
* @see #crossFade(DrawableCrossFadeFactory.Builder)
*/
@NonNull
public static DrawableTransitionOptions withCrossFade(
@NonNull DrawableCrossFadeFactory.Builder builder) {
return new DrawableTransitionOptions().crossFade(builder);
}

/**
* Returns a {@link DrawableTransitionOptions} object that uses the given transition factory.
*
* @see com.bumptech.glide.GenericTransitionOptions#with(TransitionFactory)
*/
@NonNull
public static DrawableTransitionOptions with(
@NonNull TransitionFactory transitionFactory) {
return new DrawableTransitionOptions().transition(transitionFactory);
}

/**
* Enables a cross fade animation between both the placeholder and the first resource and between
* subsequent resources (if thumbnails are used).
*/
@NonNull
public DrawableTransitionOptions crossFade() {
return crossFade(new DrawableCrossFadeFactory.Builder().setCrossFadeEnabled(true));
}

/**
* Enables a cross fade animation between both the placeholder and the first resource and between
* subsequent resources (if thumbnails are used).
*
* @param duration The duration of the animation, see {@code
* DrawableCrossFadeFactory.Builder(int)}
* @see com.bumptech.glide.request.transition.DrawableCrossFadeFactory.Builder
*/
@NonNull
public DrawableTransitionOptions crossFade(int duration) {
return crossFade(new DrawableCrossFadeFactory.Builder(duration).setCrossFadeEnabled(true));
}

/**
* Enables a cross fade animation between both the placeholder and the first resource and between
* subsequent resources (if thumbnails are used).
*/
@NonNull
public DrawableTransitionOptions crossFade(
@NonNull DrawableCrossFadeFactory drawableCrossFadeFactory) {
return transition(drawableCrossFadeFactory);
}

/**
* Enables a cross fade animation between both the placeholder and the first resource and between
* subsequent resources (if thumbnails are used).
*/
@NonNull
public DrawableTransitionOptions crossFade(@NonNull DrawableCrossFadeFactory.Builder builder) {
return crossFade(builder.build());
}
}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.