bumptech / bumptech/glide

4.8.0 still incorrectly returns a ViewTarget instead of just a Target

Open
#3,332 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
35k
Forks
6.2k
Avg merge
4d 1h
Merged PRs (30d)
8

Description

According to the documentation and the 4.8.0 release notes `into` should be returning a `Target` when using an `ImageView`
https://github.com/bumptech/glide/releases/tag/v4.8.0
https://bumptech.github.io/glide/doc/targets.html#cancellation-and-re-use
https://bumptech.github.io/glide/javadocs/400/com/bumptech/glide/RequestBuilder.html#into-android.widget.ImageView-

However it is still returning a `ViewTarget` despite the fact that the Javadoc in the source code itself states that it returns a `Target`

![ss](https://user-images.githubusercontent.com/9222661/46139592-761a5c00-c23e-11e8-8274-75a354731213.png)

As a result I cannot use the new version correctly because I am forced to use the deprecated `ViewTarget` and this keeps throwing the `Deprecated` warning until it is no longer used.

Is this intentional? If so then the documentation should reflect this behavior otherwise the code should be corrected to reflect the documentation.

Contributor guide

Open the contributing guide

Research direction

Start with the ImageView overload of RequestBuilder.into and compare its actual return type with the 4.8.0 release notes, targets documentation, and source Javadoc linked in the issue. Determine whether the implementation or documentation is authoritative, then align them and verify that callers no longer need the deprecated ViewTarget; add or update coverage if the existing test suite exposes this behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.