buildkite / buildkite/agent

Github short form plugin source doesn't handle branches with slash

Open
#783 0 comments 0 reactions 0 assignees View on GitHub
bug plugins
Dominant language
Go
Stars
1.1k
Forks
378
Avg merge
2d 6h
Merged PRs (30d)
74

Description

Docs (https://buildkite.com/docs/agent/v3/plugins#plugin-sources) describe a short form of the github plugin source (e.g. foo/bar#baz = https://github.com/foo/bar-buildkite-plugin.git#baz), however this doesn't work with a branch containing a slash:

```
- label: "Deploy"
plugins:
healthefrog/ecs-deploy#feature/fix_task_definition:
```

produces a url of `https:/healthefrog/ecs-deploy#feature/fix_task_definition`

Previously raised on docs issue tracker: https://github.com/buildkite/docs/issues/265

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.