buildkite / buildkite/agent

Submodules not disabled for git mirrors

Open
#3,286 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.1k
Forks
378
Avg merge
2d 6h
Merged PRs (30d)
74

Description

Hi, I think I've hit an edge case with git mirrors and submodules disabled with agent-stack-k8s.

It seems that `git submodule foreach --recursive "git clean -ffxdq"` gets run during git mirror updates, even when we have disabled submodules (using the agent-stack-k8s noSubmodules option which just sets the corresponding env var under the hood).

This doesn't seem to cause an issue normally, I guess because the submodules weren't initialized, but we recently had a change committed by accident which added an unused submodule without a corresponding `.gitmodules` entry. This caused the above command to complain `fatal: No url found for submodule path 'xyz' in .gitmodules` which completely broke all our builds once the commit got to main :(

It seems like when submodules are disabled, the git mirror functionality should ignore submodules as well? Or have a separate option to disable submodules for mirrors that we could set.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.