buildkite / buildkite/agent

broken header streamer after v3.48.0

Open
#2,464 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.1k
Forks
378
Avg merge
2d 6h
Merged PRs (30d)
74

Description

The ansi-timestamps experiment is enabled in v3.48.0 by default. The header line begins with `_bk;t=1698038886128~~~ `, the header streamer for header regex https://github.com/buildkite/agent/blob/24c562342c8dd3944b16bc6b87b501e304490e67/agent/header_times_streamer.go#L167C25-L167C74 broken, no header streamer anymore. The regex needs to be updated to ` headerRE = regexp.MustCompile(`^(_bk;t=\d+(?:---|~~~|\+\+\+)\s(.+))$`) ` to fix the header streamer.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.