buildkite / buildkite/agent

disabling submodules should not print a warning

Open
#1,773 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.1k
Forks
378
Avg merge
2d 6h
Merged PRs (30d)
74

Description

**Is your feature request related to a problem? Please describe.**
We have submodules disabled at the agent level, so on every build it prints a warning causing the "Preparing working directory" drawer to be expanded. This is unnecessarily noisy and causes extra mental load.

**Describe the solution you'd like**
Don't print a warning if submodules are disabled, or provide a config option to disable the warning. If users are explicitly disabling submodules, then they shouldn't need to be warned that, in fact, submodules _are_ disabled. The current behavior seems to presume that the agent-configuror has disabled submodules, but a someone working on a pipeline might expect them to be present? Either way I think that situation is not worth warning over since it is totally valid and intended behavior. Seems like it should be info-level.

**Describe alternatives you've considered**
Nothing we can really do about this output since it's hard-coded in the agent.

**Additional context**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.