buildkite / buildkite/agent

Bug: Build Skipping prevents Docker cleanup

Open
#1,547 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
1.1k
Forks
378
Avg merge
2d 6h
Merged PRs (30d)
74

Description

My buildkite jobs have lately been failing due to an inability to provision enough Docker network interfaces, similar to https://github.com/buildkite/agent/issues/277. However, most of our jobs successfully clean up their network interfaces.

I discovered that all of the jobs that failed to clean up their network interfaces failed to do so because the corresponding container was still running, and all of those containers corresponded to jobs that were canceled after a few minutes due to build skipping settings.

I haven't verified whether or not there's a zombie container every time build skipping happens.

Let me know if you need any additional information!

Contributor guide

Open the contributing guide

Research direction

Start by reproducing a Buildkite job canceled through build skipping while using Docker, then compare its cleanup behavior with jobs that complete normally. Confirm the issue is fixed when canceled jobs no longer leave their containers or Docker network interfaces running.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
ci-cd, devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.