buildkite / buildkite/agent

Reject unknown yaml tags

Open
#1,283 1 comment 2 reactions 0 assignees View on GitHub
enhancement yaml
Dominant language
Go
Stars
1.1k
Forks
378
Avg merge
2d 6h
Merged PRs (30d)
74

Description

We often get issues where folks have typing an exclamation point in some yaml by accident, and the agent parses and silently ignores the problem. Most recently, https://github.com/buildkite/agent/issues/1281.

Syntax like this, which is a "master" yaml tag, should probably throw a syntax error or something:

```yaml
step
- branches: !master
commands: echo hello world
```

Contributor guide

Open the contributing guide

Research direction

Start by tracing the agent's YAML parsing path for the example in this issue and compare its behavior with the related report in issue 1281. Reproduce the input containing `!master`, then verify that unknown YAML tags produce a syntax error instead of being silently ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, yaml
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.