buildkite / buildkite/agent-stack-k8s

Pre-exit hooks run more than once on pods with multiple containers

Open
#483 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
110
Forks
57
Avg merge
3d 8h
Merged PRs (30d)
5

Description

Hi, I noticed that when I have more than one container in a pod then the pre-exit hooks run on each container. The docs on pre-exit hooks say `Runs before the job finishes. Useful for performing cleanup tasks.` which is what I want in this case, not to have it run multiple times within the same job.

It seems like if I did want a hook to run on each container after the command finishes, then a post-command hook should do that. But this pre-exit hook behaviour seems like a bug -- let me know your thoughts!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.