buildingSMART / buildingSMART/IFC4.x-development
Pset templates missing applicability to material category
- Dominant language
- Python
- Stars
- 234
- Forks
- 123
- Avg merge
- 15h 4m
- Merged PRs (30d)
- 5
Description
This was a bit of a special behaviour back in IFC4, but in IFC4 there were definitions such as:
```
#22910= IFCPROPERTYSETTEMPLATE('3EWsy0qUqHuO00025QrE$V',$,'Pset_MaterialSteel','A set of extended mechanical properties related to steel (or other metallic and isotropic) materials.',.PSET_TYPEDRIVENOVERRIDE.,'IfcMaterial/Steel',(#22913,#22916,#22919,#22922,#22925,#22928,#22931));
#22784= IFCPROPERTYSETTEMPLATE('3Zgyu0qUmHuO00025QrE$V',$,'Pset_MaterialConcrete','A set of extended mechanical properties related to concrete materials.',.PSET_TYPEDRIVENOVERRIDE.,'IfcMaterial/Concrete',(#22787,#22790,#22793,#22796,#22799,#22802));
```
i.e. the `Pset_MaterialConcrete` only applies to `IfcMaterial` which has a `Category` attribute of `Concrete`.
One issue is that the capitalisation of `Concrete` is a mismatch with the docs which suggest `concrete`, and inconsistent with every other predefined type which is `CONCRETE`...
... but the bigger issue is that in IFC4X3, this category applicability seems to have been lost. The definition now looks like this:
```xml
Pset_MaterialConcrete
A set of extended mechanical properties related to concrete materials.
IfcMaterial
IfcMaterial
CompressiveStrength
The compressive strength of the object or material.
... etc
```
This is what it looked like in 4X2: https://github.com/buildingSMART/IFC4.3.x-development/blob/master/reference_schemas/psd_IFC4x2/Pset_MaterialConcrete.xml#L10
Is this intentional? (e.g. to clean up an anomaly in the predefined type applicability?)
Contributor guide
Research direction
Compare the IFC4X2 definition in reference_schemas/psd_IFC4x2/Pset_MaterialConcrete.xml at the linked line with the IFC4X3 definition shown in the issue. First determine whether material-category applicability was intentionally removed and how category capitalization should align; done means the intended applicability is documented and the corresponding property-set definition is corrected or confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- xml
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100