buildingSMART / buildingSMART/IDS
Tolerance in 1.0
- Dominant language
- C#
- Stars
- 318
- Forks
- 90
- PR merge metrics
- No merged PRs in 30d
Description
When implementing the tolerance check as described in https://github.com/buildingSMART/IDS/blob/development/Documentation/ImplementersDocumentation/tolerance.md a lot of the tolerance test cases fail (12). When modifying the logic a little bit (changing the > and < to inclusive comparators, >= and <=) the amount of errors goes down to only 2. So I am wondering whether the test cases are in line with the documentation for 1.0.
The remaining two test cases are:
- pass-comparison_tolerance_for_floating_point_negative_one_lower_bound (testing -1.0000020000 against -1.)
- pass-comparison_tolerance_for_floating_point_one_upper_bound (testing 1.000002 against 1.)
Based on their names these should pass, but they do not, tested in both a Java and a Python implementation.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.