btholt / btholt/complete-intro-to-react-v8
Non-implicit return added to Results.jsx in online version?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 199
- PR merge metrics
- No merged PRs in 30d
Description
Results.jsx is subtly different in text compared with the video. Specifically, on line 10 within the arrow function passed to .map() the online version uses an explicit return, while in the video it used an implicit return. Why the change? Either seems to work identically, but if there's an explanation for the change in a changeset somewhere, I've not been able to dig it out of the history.
Also, for consistency, elsewhere .map() is used with implicit returns, such as within SearchParams.jsx.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing 14-context/src/Results.jsx around line 10 with 14-context/src/SearchParams.jsx around line 59, then inspect the repository history for the change. Determine whether the project should document the distinction or make the map callback style consistent, and confirm the result against the surrounding lesson materials.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100