btholt / btholt/complete-intro-to-react-v6

[error-boundaries] Redirect isn't working by itself.

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.4k
Forks
202
PR merge metrics
No merged PRs in 30d

Description

Since `componentDidUpdate` won't be called for the 1st render, if any error happens in the first render, it won't get redirection automatically. This is mentioned in the course itself here `https://frontendmasters.com/courses/complete-react-v6/redirect-on-error/` @-0:47 seconds.

I can create a PR for a fix (here and in the other repo) in a couple of days once this issue is acknowledged/approved.
Let me know.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the error-boundary flow around componentDidUpdate and review the linked course segment on redirecting after an error. Reproduce an error during the first render; the work is done when that case redirects automatically, with the corresponding fix also considered for the other repository mentioned.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.