btholt / btholt/complete-intro-to-react-v4

Unexpected breaking change in URL encoding.

Open
#46 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.1k
Forks
238
PR merge metrics
No merged PRs in 30d

Description

# Expected
1.2.1: https://codesandbox.io/s/reach-router-starter-v1-forked-vsw3w?file=/src/index.js

after calling `navigate(encodeURIComponent("foo$bar"));`, I was brought to `/foo%24bar`

# Actual

1.3.4: https://codesandbox.io/s/reach-router-starter-v1-forked-1fyh2?file=/src/index.js

after calling `navigate(encodeURIComponent("foo$bar"));`, I was brought to `/foo%2524bar`

---

After trying several versions, this issue was introduced in 1.3.3.

Contributor guide

No contributing guide indexed for this repository

Research direction

The reproduction uses navigate(encodeURIComponent(...)) in the linked /src/index.js example; start by comparing behavior between versions 1.3.2 and 1.3.3 and inspect the URL-encoding path. Done means the input reaches /foo%24bar rather than /foo%2524bar, with a regression test if the project’s test location is identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.