btford / btford/angular-socket-io

The minified version does not correctly pass options in connect() call

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.5k
Forks
225
PR merge metrics
No merged PRs in 30d

Description

I tried to fix it, but push was not allowed.

The options (minified name e) in socket.min.js are not getting passed in connect() as it is the case in socket.js.
o=e.ioSocket||io.connect() // no argument
o=e.ioSocket||io.connect(e) // this is what it must have.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.