btford / btford/angular-modal

$rootScope versus back buttoning out of modal

Open
#49 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
231
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Our team encountered this problem:
- we raise a welcome modal on a given page
- user hits back button and welcome modal remains

Programmatically closing the modal registers as a dismissal, which
prevents it from opening on user's return to the page.

Our solution was to give the modal a local scope. Is there a good reason to put/have the modal in $rootScope?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.