btcpayserver / btcpayserver/btcpayserver-docker
Move from docker-compose to docker compose
- Dominant language
- Shell
- Stars
- 752
- Forks
- 434
- Avg merge
- 5h 38m
- Merged PRs (30d)
- 60
Description
I did a fresh install of btcpayserver-docker on the master branch and upgraded to version 2.0 just fine. Anytime I'd make a change after that, I'd run into errors like this:
```
ERROR: for ndlci_cli 'ContainerConfig'
ERROR: for tor-relay 'ContainerConfig'
ERROR: for tor 'ContainerConfig'
ERROR: for generated-configurator-1 'ContainerConfig'
ERROR: for generated-torq_db-1 'ContainerConfig'
ERROR: for generated_postgres_1 'ContainerConfig'
```
After some digging, it would appear this is related to using `docker-compose` vs `docker compose`. After some local testing, I haven't encountered any issues that indicate a good reason to stick with docker-compose. `btcpay-setup.sh` is already installing docker which comes with the `docker compose` command baked in. Am I missing something?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with btcpay-setup.sh and inspect the repository's Docker Compose command usage. Reproduce the reported ContainerConfig errors after an upgrade or configuration change, then verify that the relevant workflows use docker compose and continue to work without the legacy docker-compose command.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose, shell
- Domain
- devops, infrastructure
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100