btcpayserver / btcpayserver/BTCPayServer.Lightning

Onchain balance for LND implementations with incorrect format

Open Beginner friendly
#80 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
106
Forks
52
Avg merge
2d 1h
Merged PRs (30d)
4

Description

GetBalance functionality for LND implementation returns incorrect OnChainBalance. LND REST API Reference in /v1/balance/blockchain gets balance in sats, but in src/BTCPayServer.Lightning.LND/LndClient.cs Ln 418 amount returned from SwaggerClient is not converted properly to LightMoney, causing amount in sats is passed directly as amount in BTC.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/BTCPayServer.Lightning.LND/LndClient.cs around line 418 and compare the LND REST API Reference /v1/balance/blockchain response with the SwaggerClient value. Verify how LightMoney represents amounts and confirm that OnChainBalance reports the correct BTC value when the API returns satoshis.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.