bsl / bsl/send-sds

Utility does not properly handle WAIT when sending file.

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
22
Forks
7
PR merge metrics
No merged PRs in 30d

Description

In the method `send_file`, when `get_response` returns WAIT -- the packet number is increased regardless and the next packet is sent. The unit is then one packet behind and the ACK that is received from it is then never handled correctly by the utility.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the send_file method and tracing how get_response handles WAIT and packet numbers. Reproduce the sequence where WAIT is returned, then follow the subsequent ACK handling. Done means WAIT no longer advances the packet state or causes the next packet to be sent prematurely.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.