brysontyrrell / brysontyrrell/Patch-Starter-Script

Switch to using CFBundleVersion instead of CFBundleShortVersionString for the default

Open
#4 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
47
Forks
11
PR merge metrics
No merged PRs in 30d

Description

There is a discrepancy between definitions and patch data generated by `patchstarter.py` and Jamf's official patch feed. The official definitions do seem to be using `CFBundleVersion` and not `CFBundleShortVersionString`.

To better align with the official feed, I plan to change the behavior in `patchstarter.py` to use `CFBundleVersion`. I will include a new argument `--short-version` to force the script to reference `CFBundleShortVersionString` to preserve the original behavior for those who wish to continue using it.

Looking for comments before implementing this change.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in patchstarter.py and trace how the default bundle version key is selected and how command-line arguments are parsed. Implement the requested default and --short-version override, then verify that both version-selection paths preserve their intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.