brson / brson/mem-basics

Miri flag passing changed

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

`cargo miri test` changed to be more compatible with `cargo test`, but this means we had to find a different way to pass flags to the interpreter, so there now is a `MIRIFLAGS` environment variable for that. The old way still works for now, but is deprecated.

This affects the following line:
https://github.com/brson/mem-basics/blob/804accc5a387b67290316b77cfb6f3a22123c00d/test.sh#L20
This should now be `MIRIFLAGS="-Zmiri-disable-isolation" cargo miri test -p memcpy --target-dir="$MIRI_DIR"`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open test.sh and inspect the command at line 20, along with the linked repository revision for context. Update the command's flag-passing form and run cargo miri test for the memcpy package to confirm the Miri test still works with the target directory setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.