browserify / browserify/wzrd.in

mutli bundles and peerDependencies (state of 2018)

Open
#193 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
637
Forks
78
PR merge metrics
No merged PRs in 30d

Description

There was a thread about this several years ago (https://github.com/browserify/wzrd.in/issues/73) however I would like to start new discussion to think what we can do with current setup.

As far as I know:

Currently we have errors like this because peerDependencies are not installed:

---FLAGRANT SYSTEM ERROR---

--- error #0: ---


(logs uuid: a38dd810-e8ef-11e8-aaab-07d2929b7bb5 )

Error: "browserify exited with code 1"

code: 1
stderr: Error: Cannot find module 'react' from '/tmp/react-dom1181015-279-1woer41.gqqh/node_modules/react-dom/cjs'
    at /home/nowuser/src/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/home/nowuser/src/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/nowuser/src/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/home/nowuser/src/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/nowuser/src/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /home/nowuser/src/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:152:21)

dirPath: /tmp/react-dom1181015-279-1woer41.gqqh


------

This is probably an issue with the package, and not browserify-cdn itself.
If you feel differently, feel free to file a bug report at:

    https://github.com/browserify/wzrd.in/issues

Include the ENTIRETY of the contents of this message, and the maintainer(s)
can try to help you out.

Have a nice day!
Example CURL request:
curl 'https://wzrd.now.sh/multi' -H 'pragma: no-cache' -H 'origin: http://localhost:9292' -H 'accept-encoding: gzip, deflate, br' -H 'accept-language: en-US,en;q=0.9' -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3611.0 Safari/537.36' -H 'content-type: text/plain;charset=UTF-8' -H 'accept: */*' -H 'cache-control: no-cache' -H 'authority: wzrd.now.sh' -H 'referer: http://localhost:9292/index-dev.html?gist=b7e541a42c7c1218cad6' --data-binary '{"options":{"debug":true},"dependencies":{"react-dom":"16.6.3"}}' --compressed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the /multi endpoint and reproduce the reported React and react-dom request using the example curl command. Read the linked prior discussion and determine the expected treatment of peerDependencies; the issue is done only after that behavior is agreed and the resulting multi-bundle request succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend, build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.