browserify / browserify/module-deps

ignoreMissing not working

Open
#50 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
208
Forks
102
PR merge metrics
No merged PRs in 30d

Description

having pull request issues but if you add this at line 115

``` javascript
if( !~file.indexOf(path.sep) ) return cb(new Error(
'no path to module, and not in cache: "'+id+'" from file '
+ parent.filename
))
```

it will work... and if you need a test to verify

``` javascript
var mdeps = require('../');
var test = require('tape');

test('ignoreMissing should skip native modules if not cached', function (t) {
t.plan(1);
var p = mdeps({ignoreMissing: true});
p.on('error', function(err){ t.fail(err) } );
p.on('missing', function(msg){ t.pass(msg) } );
p.write(__dirname + '/files/ignore.js');
p.end();
});
```

with test/files/ignore.js:

``` javascript
require('fs');
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.