browserify / browserify/common-shakeify

Browserify + common-shakeify + Chart.js = infinite stack trace

Open
#52 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
103
Forks
8
PR merge metrics
No merged PRs in 30d

Description

I created this issue here: https://github.com/chartjs/Chart.js/issues/11479

### Expected behavior

I'm using browserify@17.0.0 + common-shakeify@1.1.2 + chart.js@4.4.0.

In JavaScript I have this:

```js
const Chart = require('chart.js/auto');

console.log('Hello');
```

Bundling will give me a stack trace and a crash.

### Current behavior

```
ile@ilepc:~/src/sc2/browserify-chartjs$ ./run.sh
/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/scope.js:417
var ref = new _reference2.default(node, this, assign || _reference2.default.READ, writeExpr, maybeImplicitGlobal, !!partial, !!init);
^

RangeError: Maximum call stack size exceeded
at ClassScope.__referencing (/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/scope.js:417:23)
at Referencer.Identifier (/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/referencer.js:425:33)
at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:104:34)
at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:88:26)
at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:83:38)
at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:88:26)
at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:83:38)

Node.js v20.5.1
```

### Reproducible sample

https://github.com/ile/browserify-chartjs

### Optional extra steps/info to reproduce

_No response_

### Possible solution

_No response_

### Context

_No response_

### chart.js version

v4.4.0

### Browser name and version

_No response_

### Link to your project

https://github.com/ile/browserify-chartjs

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.