browserify / browserify/common-shakeify

Breaks split-require

Open
#51 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
103
Forks
8
PR merge metrics
No merged PRs in 30d

Description

I just noticed that #43 completely breaks [split-require](https://github.com/goto-bus-stop/split-require). Only `module.exports = whatever` work, but all named exports are dropped. I've created a test case in [my fork](https://github.com/tornqvist/common-shakeify/commit/35895a0305b901498b90957497bf86a3167a2e9d) but am struggling to figure out what's wrong.

I'm not fully familiar with the inner workings of split-require and even less so in combination with common-shakeify, @goto-bus-stop, can you see why this change would break split-require?

_Originally posted by @tornqvist in https://github.com/browserify/common-shakeify/issues/43#issuecomment-1308507112_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.