brown-ccv / brown-ccv/react-volume-viewer

`volume.js` tick function should be event listeners

Open
#91 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

`grabbed`, `triggerDown` and `rayCollided` are all that change based on event listeners.

The logic is mutually exclusive - code can just be made into an event listener function
```js
if (!this.grabbed && triggerDown && this.rayCollided)
if (this.grabbed && !triggerDown)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.