brown-ccv / brown-ccv/react-volume-viewer

Figure out `onCollide` in `volume.js`

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

onCollide is called once at runtime and is always true. Not entirely sure what the code should be doing - I believe we always want it to be true anyways? That would mean we can just delete the variable nd any associated logic, otherwise fix the event listener

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in volume.js by tracing where onCollide is defined, called, and connected to the event listener. Determine whether the listener should always report true; done means either removing the unused variable and associated logic or correcting the listener so collision behavior matches the intended result, then verify it at runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.