brown-ccv / brown-ccv/react-volume-viewer

keypress-listener.js & other Aframe event listeners

Open
#83 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Event listeners for `window`, `document`, etc should be attached to `a-scene` not any individual entity.

Make sure the listeners update the volume immediately - force `volume.js` update function to run

Do we even need `keypress-listener.js`? Is turning the clipping on and off separately from the controls something the user desires?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading keypress-listener.js and volume.js, then trace where event listeners are attached to individual entities versus a-scene. Check whether the listeners can trigger volume.js updates immediately and clarify whether keypress-listener.js is still needed; done means the listener placement and clipping behavior match the intended controls.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.