brl1906 / brl1906/fmdview

Add hour and week as options to the heatmap charting function showing number of work orders completed in a given time frame.

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Jupyter Notebook
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

1. refactor the heatmap weekday_complete and month_complete to include hour and week.

2. bring this together in one function using separate functions to check the value of z_value argument in the function and call that function within the larger function to handle the separate cases. (See Clean Code, Robert Martin chapter on making good functions for guidance here.)

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the heatmap functions weekday_complete and month_complete, then trace how their z_value argument is handled and where callers pass it. Review the existing chart behavior before consolidating the cases. Done means hour and week are supported alongside the existing options through one larger function with separate value-checking functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
data-visualization
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.