brigand / brigand/babel-plugin-flow-react-proptypes

Object type spread failing on imported type from other module or libdef (e.g. flow-typed)

Open
#106 31 comments 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
427
Forks
42
PR merge metrics
No merged PRs in 30d

Description

`babel-7` branch - I'm looking into this. `found` is in a local libdef.

```javascript
import type {RoutingState} from 'found'

type Props = {
...$Exact,
classes: Object,
children?: Element<*>,
currentUser?: CurrentUser,
t: Function,
width: string,
}
```

![appframe_js_-_af_-____projects_af__-_rubymine_2017_2_eap](https://user-images.githubusercontent.com/136564/26935685-39cdfd2a-4c32-11e7-8a3f-d17a33b05e54.png)

```
TypeError: src/App/AppFrame.js: Cannot read property 'key' of undefined
at /Users/kross/projects/ui/node_modules/@alienfast/babel-plugin-flow-react-proptypes/lib/makePropTypesAst.js:154:19
at Array.map (native)
at makeObjectAstForShape (/Users/kross/projects/ui/node_modules/@alienfast/babel-plugin-flow-react-proptypes/lib/makePropTypesAst.js:153:48)
at makePropTypesAstForPropTypesAssignment (/Users/kross/projects/ui/node_modules/@alienfast/babel-plugin-flow-react-proptypes/lib/makePropTypesAst.js:43:12)
at annotate (/Users/kross/projects/ui/node_modules/@alienfast/babel-plugin-flow-react-proptypes/lib/index.js:101:85)
at /Users/kross/projects/ui/node_modules/@alienfast/babel-plugin-flow-react-proptypes/lib/index.js:181:20
at Array.forEach (native)
at PluginPass.ClassDeclaration (/Users/kross/projects/ui/node_modules/@alienfast/babel-plugin-flow-react-proptypes/lib/index.js:178:29)
at newFn (/Users/kross/projects/ui/node_modules/babel-traverse/lib/visitors.js:266:21)
at NodePath._call (/Users/kross/projects/ui/node_modules/babel-traverse/lib/path/context.js:71:18)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.