bregman-arie / bregman-arie/python-exercises

Refactor exercise

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
724
Forks
203
PR merge metrics
No merged PRs in 30d

Description

As I understand, refactoring means, to write the code in a manner to be more readable and more compact.
I don't understand, first why you needed the namedtuple function from collection, second, why isn't the loop like this:

from collections import namedtuple

Mushroom = namedtuple('Mushroom', ['name', 'poisonous'])

mushrooms = [Mushroom('Portabello', False), Mushroom('Oyster', False),
Mushroom('Death Cap', True)]

for x, i in enumerate(mushrooms):
print(x, i[0])

Also, why did you keep the counter i += 1?
The first value of enumerate, counts already
Thank you !

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.