brave / brave/security-action

Improve cast custom checker

Open
#387 1 comment 0 reactions 1 assignee Assigned to @thypon View on GitHub
bug
Dominant language
JavaScript
Stars
22
Forks
8
Avg merge
2d 6h
Merged PRs (30d)
40

Description

Reference: @bridiver

- We must transition from C-style cast rules to `static_cast`, while ensuring all C-style casts, `reinterpret_cast`, and `const_cast` are flagged, irrespective of their type.
- Please refer to the following link: https://github.com/brave/adblock-resources/pull/130#discussion_r1329316497 to verify the legitimacy of enum values. More broadly, if the value functions as a bitmask, it should ideally be classified as an enum and validated rather than merely being cast (for another example, see https://github.com/brave/adblock-resources/pull/130/files#r1329319150).

# Proposed Solution

- [ ] Remove the rule
- [x] Fork and improve the rule

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.