brave / brave/go-sync

Add rate limiting

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
367
Forks
83
Avg merge
3d 8h
Merged PRs (30d)
4

Description

Tried to add the [RateLimiter](https://github.com/brave-intl/bat-go/blob/master/middleware/rate_limiter.go#L15) in the initial implementation but it turns out it does not fit sync-server use case and we would be throttled when doing normal sync flow, so it was removed.
We should come back on this topic and add rate limiting either in ALB or in our go-sync server application.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading middleware/rate_limiter.go in the linked bat-go implementation and the go-sync server's sync flow. Determine whether the work belongs in the ALB or the Go application, and define rate limits that do not throttle normal synchronization. Done means rate limiting is implemented in the selected layer without disrupting normal sync.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.