brave / brave/go-sync

Make server use HistoryDeleteDirectiveSpecifics to remove entries from DB

Open
#178 0 comments 1 reaction 1 assignee Claimed by @DJAndries View on GitHub
Dominant language
Go
Stars
367
Forks
83
Avg merge
3d 8h
Merged PRs (30d)
4

Description

This is a follow-up for https://github.com/brave/go-sync/pull/176 .

Client's PR https://github.com/brave/brave-core/pull/20329 sends in `HistoryDeleteDirectiveSpecifics` in un-encrypted way.

Server should remove entries by `HistoryDeleteDirectiveSpecifics::global_id_directive::global_id` converted to `client_hash_tag` or by `HistoryDeleteDirectiveSpecifics::time_range_directive`.

When this issue will be resolved, `syncer::LowPriorityUserTypes` override at client must be reverted.
cc @yrliou , @DJAndries

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.