brave / brave/adblock-rust

Swap all `idna::domain_to_ascii` to `idna::domain_to_ascii_cow`

Open
#617 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

[`idna::domain_to_ascii` docs](https://docs.rs/idna/latest/idna/fn.domain_to_ascii.html) say:

> This function exists for backward-compatibility. Consider using [`domain_to_ascii_cow`](https://docs.rs/idna/latest/idna/fn.domain_to_ascii_cow.html) instead.

In the process, an `idna::AsciiDenyList` argument will be added. `EMPTY` would retain the previous behavior; `URL` may be preferred in some cases.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for every use of idna::domain_to_ascii, then read the linked idna::domain_to_ascii and idna::domain_to_ascii_cow documentation. Update each call with the appropriate AsciiDenyList choice, using EMPTY to retain previous behavior where applicable, and run the existing test suite to verify the replacements.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.