brave / brave/adblock-rust

Review all potential panics in the entire codebase.

Open
#432 5 comments 3 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

Review all potential panics.
Rewrite the code to return errors wherever it makes sense.
Comment on all cases where the panicking code is safe and explain why.

Cases:
1. `expect` or `unwrap` called in function returning a `Result`

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the entire codebase for `expect` and `unwrap`, especially calls inside functions returning a `Result`. Review each occurrence, replace panicking code with error returns where appropriate, and document why any remaining panic is safe; completion requires all cases to be reviewed and explained.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.