brave / brave/adblock-rust

Some statements can be simplified for readability

Open
#404 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

We can replace lines like

```rust
assert!(engine.check_network_request(&request).matched == *expectation,
"Expected match = {} for {} from {} typed {} against {:?}", expectation, url, source_url, request_type, rules)
```

with

```rust
assert!(engine.check_network_request(&request).matched == *expectation,
"Expected match = {expectation} for {url} from {source_url} typed {request_type} against {rules:?}")
```

to improve code readability and developer productivity.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for assertion messages that pass named values positionally, using the example in the issue as the pattern. Update applicable statements to the captured-format style, then run the existing Rust test suite and confirm the affected assertions still produce the intended messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
developer-experience
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.