brave / brave/adblock-rust

Return all filters which blocks the request

Open
#344 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

Is it possible to return all filters in `BlockerResult` for `check_network_request`?

https://github.com/brave/adblock-rust/blob/3eb8ac0e20ac1118322ab8ae2c20c0be8266028a/src/blocker.rs#L66

https://github.com/brave/adblock-rust/blob/3eb8ac0e20ac1118322ab8ae2c20c0be8266028a/src/engine.rs#L133-L135

Contributor guide

No contributing guide indexed for this repository

Research direction

Read src/blocker.rs around line 66 and src/engine.rs around lines 133-135 to trace BlockerResult and check_network_request. Determine how the result currently represents a blocking filter and what returning all matching filters requires. Done means check_network_request exposes every filter that blocks the request, with behavior verified against the existing project tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.