brave / brave/adblock-rust

Wrong types for js bindings

Open
#340 2 comments 0 reactions 1 assignee Claimed by @antonok-edm View on GitHub
js bindings
Dominant language
Rust
Stars
2.8k
Forks
250
Avg merge
1d 16h
Merged PRs (30d)
6

Description

## request_type

Current:
```ts
request_type: string
```

Expected:

```ts
request_type: RequestType // union type or enum
```
## engine.check

Current:

```ts
check(url: string, source_url: string, request_type: string, debug?: boolean): boolean;
```

Expected:
```
check(url: string, source_url: string, request_type: string, debug?: boolean): boolean | DebugObject; // it returns object with debug info if debug is true
```

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f5925b6c95f53653f35ce3f83fcda1ba9b1e04a6/types/adblock-rs/index.d.ts#L27C43-L27C65

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.